orchardmenu Issue Tracker Rss Feed

Commented Issue: Deadlock occuring in Orchard DB [28]

pszmyd — Thu, 24 Jan 2013 17:56:26 GMT

Hi, we are experiencing deadlocks on our production cms almost daily now.
We are running 1.6 of Orchard.
I've attached an error from Spotlight, our db monitoring tool.

Any help would be much appreciated.

Comments: Is it related to Navigation module in any way, as I can't see anything related in the attached log. Try changing transaction mode to ReadUncommitted inside TransactionManager class - it should help get rid of most of the deadlocks.

Created Issue: Deadlock occuring in Orchard DB [28]

ant0ny — Thu, 24 Jan 2013 16:29:28 GMT

Commented Issue: Upgraded to 1.5.1 from 1.4.2 instance with advanced menus module enabled and getting the below yellow screen errors: [27]

jackinthegreen — Wed, 22 Aug 2012 15:45:21 GMT

[MissingMethodException: Method not found: 'Void Orchard.UI.Navigation.NavigationManager..ctor(System.Collections.Generic.IEnumerable`1<Orchard.UI.Navigation.INavigationProvider>, Orchard.Security.IAuthorizationService, System.Web.Mvc.UrlHelper, Orchard.IOrchardServices)'.]
Szmyd.Orchard.Modules.Menu.Providers.HackedNavigationManager..ctor(INavigationProviderFactory factory, IAuthorizationService authorizationService, UrlHelper urlHelper, IOrchardServices orchardServices) +0

[DependencyResolutionException: An exception was thrown while invoking the constructor 'Void .ctor(Szmyd.Orchard.Modules.Menu.Providers.INavigationProviderFactory, Orchard.Security.IAuthorizationService, System.Web.Mvc.UrlHelper, Orchard.IOrchardServices)' on type 'HackedNavigationManager'.]
Autofac.Core.Activators.Reflection.ConstructorParameterBinding.Instantiate() +451
Comments: Is this because that Orchard Method is gone from 1.5.1? Thanks!

Created Issue: Upgraded to 1.5.1 from 1.4.2 instance with advanced menus module enabled and getting the below yellow screen errors: [27]

jackinthegreen — Wed, 22 Aug 2012 15:42:26 GMT

Commented Issue: Creating new content with Menu Relation part crashes backend [20]

dbonnell — Wed, 18 Jul 2012 00:45:15 GMT

I added the module (1.4.1) via the gallery and when I attach the Menu Relation part to my content type and attempt to create a new item I get the following error message:

Object reference not set to an instance of an object.

Line 7: <legend>@T("Show this item on menu(s)")</legend>
Line 8: @if (Model.Menus.Count() > 0) {
Line 9: foreach (var entry in Model.Menus) {
Line 10: <fieldset>

Source File: \Modules\Szmyd.Orchard.Modules.Menu\Views\EditorTemplates\Parts\Menu.RelationPart.cshtml Line: 8

I do have one menu created that displays one "tab" item with two other options in the drop down so I think it is installed properly.
Comments: I just hit the same issue and as the fix has not officially been released yet I thought I would share it here to save others some time. Below are the two changes from the latest code on the default fork that I pulled in to my 1.4.1 build to fix this issue. Views\EditorTemplates\Parts\MenuRelationPart.cshtml, line# 8 needs to be changed to: @if (Model.Menus.Any()) { Drivers\Menu.RelationPartDriver.cs, line# 46 needs to be changed to: MenuText = part.ContentItem.ContentManager.GetItemMetadata(part).DisplayText,

Commented Issue: Deadlocking on GetMenus [3]

Sarkie — Mon, 18 Jun 2012 12:39:05 GMT

Hi,

We have released your module to our server and are constantly getting deadlock situations, also running it with NHProf shows quite a lot of issues, (that may be fixed with 1.4)

The site has the menu set as the Header and the Footer so is on every page.

We think that they are editing the menu whilst the site is being used.

Any help would be appreciated.

Comments: Got another Dead Lock, here's the error log output. 2012-06-18 13:35:30 - ,470 [8] Orchard.ContentManagement.Drivers.Coordinators.ContentPartDriverCo... ,470 [8] Orchard.ContentManagement.Drivers.Coordinators.ContentPartDriverCoordinator - NullReferenceException thrown from IContentPartDriver by Szmyd.Orchard.Modules.Menu.Drivers.MenuWidgetPartDriver System.NullReferenceException: Object reference not set to an instance of an object. at Orchard.ContentManagement.DefaultContentManager.Get(Int32 id, VersionOptions options, QueryHints hints) in d:\Builds\OrchardFull\src\Orchard\ContentManagement\DefaultContentManager.cs:line 190 at System.Linq.Enumerable.WhereSelectListIterator`2.MoveNext() at System.Collections.Generic.List`1..ctor(IEnumerable`1 collection) at System.Linq.Enumerable.ToList[TSource](IEnumerable`1 source) at Orchard.ContentManagement.DefaultContentQuery.ContentQuery`1.Orchard.ContentManagement.IContentQuery<T>.List() in d:\Builds\OrchardFull\src\Orchard\ContentManagement\DefaultContentQuery.cs:line 191 at Szmyd.Orchard.Modules.Menu.Services.MenuService.GetMenus() at Szmyd.Orchard.Modules.Menu.Providers.NavigationProviderFactory.<get_Providers>d__2.MoveNext() at Orchard.UI.Navigation.NavigationManager.<GetSources>d__c.MoveNext() in d:\Builds\OrchardFull\src\Orchard\UI\Navigation\NavigationManager.cs:line 90 at System.Linq.Enumerable.<SelectManyIterator>d__14`2.MoveNext() at System.Linq.Buffer`1..ctor(IEnumerable`1 source) at System.Linq.Enumerable.ToArray[TSource](IEnumerable`1 source) at Orchard.UI.Navigation.NavigationManager.Merge(IEnumerable`1 sources) in d:\Builds\OrchardFull\src\Orchard\UI\Navigation\NavigationManager.cs:line 131 at Orchard.UI.Navigation.NavigationManager.BuildMenu(String menuName) in d:\Builds\OrchardFull\src\Orchard\UI\Navigation\NavigationManager.cs:line 29 at Szmyd.Orchard.Modules.Menu.Drivers.MenuWidgetPartDriver.<>c__DisplayClassd.<Display>b__8() at Orchard.ContentManagement.Drivers.ContentPartDriver`1.<>c__DisplayClassd.<ContentShape>b__c(BuildShapeContext ctx) in d:\Builds\OrchardFull\src\Orchard\ContentManagement\Drivers\ContentPartDriver.cs:line 108 at Orchard.ContentManagement.Drivers.ContentPartDriver`1.<>c__DisplayClass13.<ContentShapeImplementation>b__12(BuildShapeContext ctx) in d:\Builds\OrchardFull\src\Orchard\ContentManagement\Drivers\ContentPartDriver.cs:line 116 at Orchard.ContentManagement.Drivers.ContentShapeResult.ApplyImplementation(BuildShapeContext context, String displayType) in d:\Builds\OrchardFull\src\Orchard\ContentManagement\Drivers\ContentShapeResult.cs:line 37 at Orchard.InvokeExtensions.Invoke[TEvents](IEnumerable`1 events, Action`1 dispatch, ILogger logger) in d:\Builds\OrchardFull\src\Orchard\InvokeExtensions.cs:line 19 2012-06-18 13:35:30 - ,017 [8] Orchard.ContentManagement.Drivers.Coordinators.ContentPartDriverCo... ,017 [8] Orchard.ContentManagement.Drivers.Coordinators.ContentPartDriverCoordinator - ADOException thrown from IContentPartDriver by Szmyd.Orchard.Modules.Menu.Drivers.MenuWidgetPartDriver NHibernate.ADOException: could not execute query [ SELECT this_.Id as Id180_3_, this_.Number as Number180_3_, this_.Published as Published180_3_, this_.Latest as Latest180_3_, this_.Data as Data180_3_, this_.ContentItemRecord_id as ContentI6_180_3_, contentite1_.Id as Id179_0_, contentite1_.Data as Data179_0_, contentite1_.ContentType_id as ContentT3_179_0_, advancedme2_.Id as Id176_1_, advancedme2_.Name as Name176_1_, contenttyp6_.Id as Id181_2_, contenttyp6_.Name as Name181_2_ FROM Orchard_Framework_ContentItemVersionRecord this_ inner join Orchard_Framework_ContentItemRecord contentite1_ on this_.ContentItemRecord_id=contentite1_.Id inner join Szmyd_Orchard_Modules_Menu_AdvancedMenuPartRecord advancedme2_ on contentite1_.Id=advancedme2_.Id left outer join Orchard_Framework_ContentTypeRecord contenttyp6_ on contentite1_.ContentType_id=contenttyp6_.Id WHERE this_.Published = @p0 ] Positional parameters: #0>True [SQL: SELECT this_.Id as Id180_3_, this_.Number as Number180_3_, this_.Published as Published180_3_, this_.Latest as Latest180_3_, this_.Data as Data180_3_, this_.ContentItemRecord_id as ContentI6_180_3_, contentite1_.Id as Id179_0_, contentite1_.Data as Data179_0_, contentite1_.ContentType_id as ContentT3_179_0_, advancedme2_.Id as Id176_1_, advancedme2_.Name as Name176_1_, contenttyp6_.Id as Id181_2_, contenttyp6_.Name as Name181_2_ FROM Orchard_Framework_ContentItemVersionRecord this_ inner join Orchard_Framework_ContentItemRecord contentite1_ on this_.ContentItemRecord_id=contentite1_.Id inner join Szmyd_Orchard_Modules_Menu_AdvancedMenuPartRecord advancedme2_ on contentite1_.Id=advancedme2_.Id left outer join Orchard_Framework_ContentTypeRecord contenttyp6_ on contentite1_.ContentType_id=contenttyp6_.Id WHERE this_.Published = @p0] ---> System.Data.SqlClient.SqlException: Transaction (Process ID 130) was deadlocked on lock resources with another process and has been chosen as the deadlock victim. Rerun the transaction. at System.Data.SqlClient.SqlConnection.OnError(SqlException exception, Boolean breakConnection) at System.Data.SqlClient.TdsParser.ThrowExceptionAndWarning() at System.Data.SqlClient.TdsParser.Run(RunBehavior runBehavior, SqlCommand cmdHandler, SqlDataReader dataStream, BulkCopySimpleResultSet bulkCopyHandler, TdsParserStateObject stateObj) at System.Data.SqlClient.SqlDataReader.HasMoreRows() at System.Data.SqlClient.SqlDataReader.ReadInternal(Boolean setTimeout) at NHibernate.Driver.NHybridDataReader.Read() at NHibernate.Loader.Loader.DoQuery(ISessionImplementor session, QueryParameters queryParameters, Boolean returnProxies) at NHibernate.Loader.Loader.DoQueryAndInitializeNonLazyCollections(ISessionImplementor session, QueryParameters queryParameters, Boolean returnProxies) at NHibernate.Loader.Loader.DoList(ISessionImplementor session, QueryParameters queryParameters) --- End of inner exception stack trace --- at NHibernate.Loader.Loader.DoList(ISessionImplementor session, QueryParameters queryParameters) at NHibernate.Loader.Loader.ListIgnoreQueryCache(ISessionImplementor session, QueryParameters queryParameters) at NHibernate.Loader.Criteria.CriteriaLoader.List(ISessionImplementor session) at NHibernate.Impl.SessionImpl.List(CriteriaImpl criteria, IList results) at NHibernate.Impl.CriteriaImpl.List(IList results) at NHibernate.Impl.CriteriaImpl.List[T]() at Orchard.ContentManagement.DefaultContentQuery.ContentQuery`1.Orchard.ContentManagement.IContentQuery<T>.List() in d:\Builds\OrchardFull\src\Orchard\ContentManagement\DefaultContentQuery.cs:line 191 at Szmyd.Orchard.Modules.Menu.Services.MenuService.GetMenus() at Szmyd.Orchard.Modules.Menu.Providers.NavigationProviderFactory.<get_Providers>d__2.MoveNext() at Orchard.UI.Navigation.NavigationManager.<GetSources>d__c.MoveNext() in d:\Builds\OrchardFull\src\Orchard\UI\Navigation\NavigationManager.cs:line 90 at System.Linq.Enumerable.<SelectManyIterator>d__14`2.MoveNext() at System.Linq.Buffer`1..ctor(IEnumerable`1 source) at System.Linq.Enumerable.ToArray[TSource](IEnumerable`1 source) at Orchard.UI.Navigation.NavigationManager.Merge(IEnumerable`1 sources) in d:\Builds\OrchardFull\src\Orchard\UI\Navigation\NavigationManager.cs:line 131 at Orchard.UI.Navigation.NavigationManager.BuildMenu(String menuName) in d:\Builds\OrchardFull\src\Orchard\UI\Navigation\NavigationManager.cs:line 29 at Szmyd.Orchard.Modules.Menu.Drivers.MenuWidgetPartDriver.<>c__DisplayClassd.<Display>b__8() at Orchard.ContentManagement.Drivers.ContentPartDriver`1.<>c__DisplayClassd.<ContentShape>b__c(BuildShapeContext ctx) in d:\Builds\OrchardFull\src\Orchard\ContentManagement\Drivers\ContentPartDriver.cs:line 108 at Orchard.ContentManagement.Drivers.ContentPartDriver`1.<>c__DisplayClass13.<ContentShapeImplementation>b__12(BuildShapeContext ctx) in d:\Builds\OrchardFull\src\Orchard\ContentManagement\Drivers\ContentPartDriver.cs:line 116 at Orchard.ContentManagement.Drivers.ContentShapeResult.ApplyImplementation(BuildShapeContext context, String displayType) in d:\Builds\OrchardFull\src\Orchard\ContentManagement\Drivers\ContentShapeResult.cs:line 37 at Orchard.InvokeExtensions.Invoke[TEvents](IEnumerable`1 events, Action`1 dispatch, ILogger logger) in d:\Builds\OrchardFull\src\Orchard\InvokeExtensions.cs:line 19 2012-06-18 13:35:30 - ,001 [8] NHibernate.Util.ADOExceptionReporter - Transaction (Process ID 130... ,001 [8] NHibernate.Util.ADOExceptionReporter - Transaction (Process ID 130) was deadlocked on lock resources with another process and has been chosen as the deadlock victim. Rerun the transaction.

Created Issue: Yellow Screen of death in case of Content type with Autoroute part, but without TitlePart [26]

musukvl — Tue, 05 Jun 2012 08:40:53 GMT

AdvancedMenuItemPartDriver.Editor

Text = string.Format("{1}:\t{0}", x.As<TitlePart>().Title, x.ContentItem.TypeDefinition.DisplayName

Will fail in case of Content type with Autoroute part, but without TitlePart.
I think there is Driver.GetContentItemMetadata should used, or code like
Text = string.Format("{1}:\t{0}", (x.As<TitlePart>() != null) ? x.As<TitlePart>().Title : x.As<AutoroutePart>().Path, x.ContentItem.TypeDefinition.DisplayName),

Created Issue: Issues when debugging and loading Admin [25]

Sarkie — Thu, 17 May 2012 11:23:58 GMT

When I load admin with debugger, I'll get this error.

'Orchard.DisplayManagement.Implementation.DefaultShapeFactory' does not contain a definition for 'Menu'

In
MenuFilter.cs line 48 or MenuName...

Created Issue: Can't set Menu Item to (None) [24]

Sarkie — Thu, 17 May 2012 09:14:33 GMT

Once I've created a Menu Item using a Content Item, when I go in and change it to a static url and change the Content Item to be (None). It'll set the Static Url but not set the Content Item.

Commented Issue: Cannot use a leading .. to exit above the top directory. [23]

Sarkie — Fri, 11 May 2012 13:10:52 GMT

I keep getting this issue, I'll look into it more tomorrow.

If I debug it, it seems to be getting called twice. First time, it works fine, second time this error.

I have two menus on the page.

One of them has

url = "/"
url ="/news/"
url="http://www.google.com"

In case that helps you, I'll be looking into it more tomorrow.

2012-05-10 17:26:52,837 [28] Orchard.ContentManagement.Drivers.Coordinators.ContentPartDriverCoordinator - HttpException thrown from IContentPartDriver by Szmyd.Orchard.Modules.Menu.Drivers.MenuWidgetPartDriver
System.Web.HttpException (0x80004005): Cannot use a leading .. to exit above the top directory.
at System.Web.Util.UrlPath.ReduceVirtualPath(String path)
at System.Web.Util.UrlPath.Reduce(String path)
at System.Web.VirtualPath.Combine(VirtualPath relativePath)
at System.Web.Mvc.PathHelpers.GenerateClientUrlInternal(HttpContextBase httpContext, String contentPath)
at System.Web.Mvc.UrlHelper.GenerateUrl(String routeName, String actionName, String controllerName, RouteValueDictionary routeValues, RouteCollection routeCollection, RequestContext requestContext, Boolean includeImplicitMvcValues)
at System.Web.Mvc.UrlHelper.GenerateUrl(String routeName, String actionName, String controllerName, String protocol, String hostName, String fragment, RouteValueDictionary routeValues, RouteCollection routeCollection, RequestContext requestContext, Boolean includeImplicitMvcValues)
at System.Web.Mvc.UrlHelper.RouteUrl(RouteValueDictionary routeValues)
at Orchard.UI.Navigation.NavigationManager.GetUrl(String menuItemUrl, RouteValueDictionary routeValueDictionary) in C:\Work\svnroot\OrchardSource\1.4.0\src\Orchard\UI\Navigation\NavigationManager.cs:line 46
at Orchard.UI.Navigation.NavigationManager.FinishMenu(IEnumerable`1 menuItems) in C:\Work\svnroot\OrchardSource\1.4.0\src\Orchard\UI\Navigation\NavigationManager.cs:line 38
at Orchard.UI.Navigation.NavigationManager.BuildMenu(String menuName) in C:\Work\svnroot\OrchardSource\1.4.0\src\Orchard\UI\Navigation\NavigationManager.cs:line 29
at Szmyd.Orchard.Modules.Menu.Drivers.MenuWidgetPartDriver.<>c__DisplayClassd.<Display>b__8() in c:\Work\svnroot\Site\Modules\Szmyd.Orchard.Modules.Menu\Drivers\MenuWidgetPartDriver.cs:line 46
at Orchard.ContentManagement.Drivers.ContentPartDriver`1.<>c__DisplayClassd.<ContentShape>b__c(BuildShapeContext ctx) in C:\Work\svnroot\OrchardSource\1.4.0\src\Orchard\ContentManagement\Drivers\ContentPartDriver.cs:line 108
at Orchard.ContentManagement.Drivers.ContentPartDriver`1.<>c__DisplayClass13.<ContentShapeImplementation>b__12(BuildShapeContext ctx) in C:\Work\svnroot\OrchardSource\1.4.0\src\Orchard\ContentManagement\Drivers\ContentPartDriver.cs:line 116
at Orchard.ContentManagement.Drivers.ContentShapeResult.ApplyImplementation(BuildShapeContext context, String displayType) in C:\Work\svnroot\OrchardSource\1.4.0\src\Orchard\ContentManagement\Drivers\ContentShapeResult.cs:line 37
at Orchard.ContentManagement.Drivers.ContentShapeResult.Apply(BuildDisplayContext context) in C:\Work\svnroot\OrchardSource\1.4.0\src\Orchard\ContentManagement\Drivers\ContentShapeResult.cs:line 21
at Orchard.ContentManagement.Drivers.Coordinators.ContentPartDriverCoordinator.<>c__DisplayClassa.<BuildDisplay>b__9(IContentPartDriver driver) in C:\Work\svnroot\OrchardSource\1.4.0\src\Orchard\ContentManagement\Drivers\Coordinators\ContentPartDriverCoordinator.cs:line 49
at Orchard.InvokeExtensions.Invoke[TEvents](IEnumerable`1 events, Action`1 dispatch, ILogger logger) in C:\Work\svnroot\OrchardSource\1.4.0\src\Orchard\InvokeExtensions.cs:line 19

Comments: Follow up. So it seems the Parts are getting called twice, for each Part. So I have two menus, Header and Footer. Each gets called twice. The first time they'll work and no errors, the second time = boom. In the old site, the menu items were just pure links, this time it was mix, urls and content items. The urls in the content item are "drink/", I don't know if this is causing it to go boom. I've tried debugging it to no avail. I've gone back to just using urls for a work-a-round.

Created Issue: Cannot use a leading .. to exit above the top directory. [23]

Sarkie — Thu, 10 May 2012 16:32:18 GMT

Closed Issue: Missing TitlePart [22]

pszmyd — Wed, 25 Apr 2012 17:34:03 GMT

Hi,

For my Custom Types I don't use a TitlePart, I implement ITitleAspect. So when creating a new item, it'll crash on this line in AdvancedMenuItemPartDriver.cs

Text = string.Format( "{1}:\t{0}", x.As<TitlePart>().Title, x.ContentItem.TypeDefinition.DisplayName )

Since it'll fail the As conversion.

You should replace that line with.

Text = x.ContentItem.ContentManager.GetItemMetadata( x ).DisplayText,

as noted here by Bertrand
http://orchard.codeplex.com/discussions/311109

Cheers, Sarkie
Comments: Applied fix as suggested by @Sarkie. Fixed in changeset 579418de16ca.

Reopened Issue: Missing TitlePart [22]

pszmyd — Wed, 25 Apr 2012 17:33:14 GMT

Commented Issue: Missing TitlePart [22]

Sarkie — Wed, 25 Apr 2012 16:30:43 GMT

Hi,

For my Custom Types I don't use a TitlePart, I implement ITitleAspect. So when creating a new item, it'll crash on this line in AdvancedMenuItemPartDriver.cs

Text = string.Format( "{1}:\t{0}", x.As<TitlePart>().Title, x.ContentItem.TypeDefinition.DisplayName )

Since it'll fail the As conversion.

You should replace that line with.

Text = x.ContentItem.ContentManager.GetItemMetadata( x ).DisplayText,

as noted here by Bertrand
http://orchard.codeplex.com/discussions/311109

Cheers, Sarkie
Comments: Pretty sure you are meant to use the code I've suggested from here http://orchard.codeplex.com/discussions/311109 , instead of using .As<ITitleAspect> in case they change that interface in the future.

Closed Issue: Missing TitlePart [22]

pszmyd — Wed, 25 Apr 2012 14:13:11 GMT

Commented Issue: Missing TitlePart [22]

pszmyd — Wed, 25 Apr 2012 13:57:16 GMT

Commented Issue: Missing TitlePart [22]

Sarkie — Wed, 25 Apr 2012 10:21:02 GMT

Hi,

For my Custom Types I don't use a TitlePart, I implement ITitleAspect. So when creating a new item, it'll crash on this line in AdvancedMenuItemPartDriver.cs

Text = string.Format( "{1}:\t{0}", x.As<TitlePart>().Title, x.ContentItem.TypeDefinition.DisplayName )

Since it'll fail the As conversion.

You should replace that line with.

Text = x.ContentItem.ContentManager.GetItemMetadata( x ).DisplayText,

as noted here by Bertrand
http://orchard.codeplex.com/discussions/311109

Cheers, Sarkie
Comments: Also noticed usage in MenuAdminController, BreadcrumbsPartDriver, MenuRelationPartDriver, RecentlySeenPartDriver

Created Issue: Missing TitlePart [22]

Sarkie — Wed, 25 Apr 2012 10:14:43 GMT

Created Issue: NullReferenceException when breadcrumb widget is displayed on a non-content item [21]

Piedone — Tue, 03 Apr 2012 15:53:59 GMT

...like any other traditional MVC action. BreadcrumbsPartDriver ln 55 throws, as the var current is null.

Commented Issue: Creating new content with Menu Relation part crashes backend [20]

pszmyd — Fri, 30 Mar 2012 02:51:18 GMT